Jan 22, 2019, 02:59 pm

News:

Please, come on in and check things out. It would be our pleasure :)


Updated to RC1

Started by Bigguy, Dec 28, 2018, 08:32 pm

Previous topic - Next topic

0 Members and 1 Guest are viewing this topic.

Skhilled

Attachments work on my test site that I just setup this morning. Make sure that your server has what's outlined in the readme.html for "Minimum installation requirements" and "Recommendations for best performance" as stated in the readme.html file that is included in in the smf 2.1 download.

QuoteMinimum installation requirements
Your server must meet a few requirements to be able to run SMF. If you are unsure as to whether your webserver meets these, please try to upgrade anyway - it should detect any problems.

Any webserver that properly supports PHP, such as Apache or Internet Information Services (IIS).
PHP 5.4.0 or higher. The following directives are required to be set correctly in php.ini:
the engine directive must be On.
the magic_quotes_sybase directive must be set to Off.
the session.save_path directive must be set to a valid directory.
the file_uploads directive must be On.
the upload_tmp_dir must be set to a valid directory.
Any of the following database systems
MySQL 5.0.22/5.1.10 or higher.
MariaDB 5.1.10 or higher.
PostgreSQL 9.4 or higher.
at least 2 megabytes of storage space in the database, although more is highly recommended.
The database user must have at least the following privileges: SELECT, INSERT, UPDATE, DELETE, ALTER, CREATE, DROP, TRUNCATE and INDEX.
about 20 megabytes of storage space on the web server, although more is recommended.

Recommendations for best performance
Windows, Linux or another Unix based operating system.
the GNU Aspell 0.50 or higher and its dictionaries for spell checking functionality.
Apache 2.0.0 or higher with AcceptPathInfo set to On (Apache 2 and later only) for queryless URL support.
PHP 7.0.0 or higher, with the following set in php.ini:
the max_input_time directive is set to a value of at least 30.
the post_max_size and upload_max_filesize directives set to the size of the largest attachments you wish to be able to upload.
the session.use_trans_sid directive set to Off.
the memory_limit directive is set to at least 8M.
the max_execution_time directive is set to at least 15.
the register_globals directive is set to Off.
the safe mode disabled or suEXEC enabled.
Any of the following database systems
MySQL 8.0 or higher.
MariaDB 10.2 or higher.
PostgreSQL 9.5 or higher.
GD Graphics Library 2.0 or higher.
If your server does not meet these requirements, SMF may not work properly.

Bigguy

Mine has all that as far as I know. :)

Skhilled

Yours and mine works but everyone else's doesn't seem to wanna work. LOL

Bigguy

I think it pays to watch GH and update just after they have made a crap load of merges. After they do that they take a break for a day or two...that's when to update, on their break. ;)

lurkalot

Quote from: Skhilled on Jan 06, 2019, 10:30 amYours and mine works but everyone else's doesn't seem to wanna work. LOL

Mine works too. ;) It might be a TP related thing under certain scenarios.  We're looking into it.

@rjen

Jan 06, 2019, 02:01 pm #65 Last Edit: Jan 06, 2019, 02:07 pm by @rjen
Yep, it is TP related. It turns out that we load Jquery twice in the (very specific) case that the Jquery location is not yet set in a 2.1 install.

Set it once and it works (and stays working)...

You cannot see attachments on this board.

We'll make sure this gets addressed when TP 162 is released...

@rjen

So it's not just yours that works...  :D

By the way, the notifications here are still all over the place...  :lol

Bigguy

That's great to hear. Another bug found and squashed almost. :)

EDIT: Yeah I know. They will get fixed. (notifications) :(

chen_zhen


Assuming you are using like Source files for both branches..
Imo just run a check on whether SMF 2.1 is being used prior to loading the library for SMF 2.0.
Then you can also use a dynamic load of jQuery if the jQuery function is not available in SMF 2.0 branch.

@rjen

That's pretty much what is happening. It turns out that upon install 2.1 does NOT set any value in the Jquery source field.

So we need to add an extra check in TP or users need to set a source location manually in SMF.

A bit sloppy of the SMF install imo...

chen_zhen

SMF 2.1 branch has jQuery library by default so you simply need to check for the forum version.

Code Select
global $modSettings;
$version = version_compare((!empty($modSettings['smfVersion']) ? substr($modSettings['smfVersion'], 0, 3) : '2.0'), '2.1', '<') ? 'v2.0' : 'v2.1';

However, SMF 2.0 branch may have a jQuery library being loaded by another modification.
For that branch it might be best to have a checkbox setting to load the library or not.

The reason why "jQuery" does not register in javascript has 2 reasons:
  • The document/window must be loaded first
  • Even after the document has loaded it may take a second for the library to load

There is a way around this but it leaves a noticeable 1 second delay.

chen_zhen


For the SMF 2.0 branch, I would just do the checkbox in the settings but if you want to mess around with some js:

Code Select
<script type="text/javascript"><!-- // --><![CDATA[
function smfTpCheckjQueryLoad() {
var tpInterval, tpIntervalCount=0;
tpInterval = setInterval(function(){
if (typeof jQuery === "function") {
clearInterval(tpInterval);
console.log("TP ~ jQuery loaded");
}
else if (tpIntervalCount >= 50) {
var tpJqueryScriptId = document.createElement("script");
tpJqueryScriptId.src = smf_default_theme_url + "/scripts/jquery.min.js?tp2";
document.body.appendChild(tpJqueryScriptId);
clearInterval(tpInterval);
console.log("TP ~ jQuery library loaded by TP after 5 seconds");
}
else {
console.log("TP ~ waiting for jQuery to load...");
tpIntervalCount++;
}
}, 100);
}

if (window.addEventListener)
window.addEventListener("load", smfTpCheckjQueryLoad, false);
else if (window.attachEvent)
window.attachEvent("onload", smfTpCheckjQueryLoad);
else
window.onload = smfTpCheckjQueryLoad;
// ]]></script>

.. this will allow 5 seconds for jQuery to load in the window else it will load your library when that fails.

@rjen

Thanks for the input, but we already fixed it for 1.6.2....

xMaster

Hello, I have a question.
Since the RC1 always has new change makes you there always a database update? Or are you just dubbing the php files?
Sorry for my bad English

Bigguy

Everytime this site gets updated I run the upgrader in case there are changes to the database.